-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 1471 german labels 2 #1868
Conversation
src/ontology/edits/oeo-social.omn
Outdated
@@ -2399,6 +2428,8 @@ pull request: https://github.com/OpenEnergyPlatform/ontology/pull/944 | |||
move govern axioms to oeo-shared-axioms | |||
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1399 | |||
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1724", | |||
rdfs:comment "EU-EHS"@de, | |||
rdfs:comment "Emissionshandelssystem der Europäischen Union"@de, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two should be implemented as alternative label
and not as rdfs:comment
src/ontology/edits/oeo-social.omn
Outdated
@@ -2457,6 +2490,7 @@ pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1462 | |||
move axiom to oeo-shared-axioms | |||
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1399 | |||
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1724", | |||
rdfs:comment "EU-Klimapolitik"@de, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be alternative label
instead of rdf:comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggestions on specific lines.
Co-authored-by: l-emele <[email protected]>
Co-authored-by: l-emele <[email protected]>
Co-authored-by: l-emele <[email protected]>
Co-authored-by: l-emele <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction from rdfs:comment to alternative label
I also updated the google doc sheet and implemented the suggested changes from @l-emele |
Co-authored-by: Vismaya RLI <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I committed your latest changes and updated/fixed CHANGELOG.md.
Now everything looks fine and I thus approve.
I just say that this PR was behind the dev branch, so I merged dev and fixed resulting merge conflicts. |
Summary of the discussion
I implemented several new german alternative labels, please check if everything is correct. To check see also the google doc https://docs.google.com/spreadsheets/d/1snsx6zF8dqXGM9WCX0EckrdGnorrB9lMnvdvP2fx9ZQ/edit#gid=687082420
I also implemented the english language tag to already existing english alternative labels.
Workflow checklist
Automation
Closes #
PR-Assignee
term tracker item
Reviewer